nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

As we transition to the new Hyland Community, some post links may be temporarily disrupted as we finalize redirects. We apologize for the inconvenience and are working to resolve this as quickly as possible. Details.

Sub Process as Compensation Handler

gokceng1

Hi,

I noticed that org.activiti.bpmn.converter.parser.SubProcessParser.parse method does not check org.activiti.bpmn.constants.BpmnXMLConstants.ATTRIBUTE_ACTIVITY_ISFORCOMPENSATION property. So deploying subprocess which has isForCompensation="true" causes

Caused by: org.activiti.engine.ActivitiException: Errors while parsing:
compensation boundary catch must be connected to element with isForCompensation=true | _38 | line 169 | column 86
at org.activiti.engine.impl.bpmn.parser.BpmnParse.execute(BpmnParse.java:191) ~[activiti-engine-5.12.jar:5.12]
….

at org.activiti.engine.impl.bpmn.parser.handler.AbstractBpmnParseHandler line 236. Is this a bug?

If it is, may I contribute to this, I worked hard to find it

Find more posts tagged with

Comments

frederikherema1

This is indeed an issue. Feel free to create a pull-request for this or suggest a patch

gokceng1

Thank you frederik, I will check it out

Edit: http://docs.codehaus.org/display/ACT/Developers+Guide, is this link up-to-date?

jbarrez

No, unfortunately not.

Basically you 'fork' the repository of Activiti on Github (https://github.com/Activiti/Activiti), clone the repo to your local machine, o some changes, commit and push them, and open a pull request through the pull request mechanism of github.

gokceng1

Thank you joram, I'm not familiar with github but tonight I will try to accomplish this issue.

jbarrez

If you got any problems doing so, just posts and we'll try to help you along the way!

gokceng1

Hey, thank you for your kindness.
I get the project, I'm using Intellij Idea. I tried Eclipse Juno but it didn't see any projects in root, I'm surprised. Anyway, I opened the projects in Idea, maven clean, compile worked. There are some tests that are not passing, I don't know whether they are important. Here:

<br>Tests in error: <br>&nbsp; testDeployRevisedProcessAfterDeleteOnOtherProcessEngine(org.activiti.engine.test.cache.ProcessDefinitionCacheTest)<br>&nbsp; testStartProcessInstanceByIdAfterReboot(org.activiti.engine.test.cache.ProcessDefinitionCacheTest)<br><br>Tests run: 1079, Failures: 0, Errors: 2, Skipped: 0<br><br>[INFO] ————————————————————————<br>[INFO] Reactor Summary:<br>[INFO] <br>[INFO] Activiti …………………………………… SUCCESS [0.001s]<br>[INFO] Activiti - BPMN Model ……………………….. SUCCESS [2.470s]<br>[INFO] Activiti - BPMN Converter ……………………. SUCCESS [1.734s]<br>[INFO] Activiti - Engine …………………………… FAILURE [2:04.757s]<br>[INFO] Activiti - Spring …………………………… SKIPPED<br>[INFO] Activiti - BPMN Layout ………………………. SKIPPED<br>[INFO] Activiti - JSON Converter ……………………. SKIPPED<br>[INFO] Activiti - Simple Workflow …………………… SKIPPED<br>[INFO] Activiti - REST - Common …………………….. SKIPPED<br>[INFO] Activiti - Modeler ………………………….. SKIPPED<br>[INFO] Activiti - Diagram - REST ……………………. SKIPPED<br>[INFO] Activiti - Explorer …………………………. SKIPPED<br>[INFO] Activiti - Rest - Classes ……………………. SKIPPED<br>[INFO] Activiti - Rest …………………………….. SKIPPED<br>[INFO] Activiti - Webapp - Explorer V2 ………………. SKIPPED<br>[INFO] Activiti - Cxf ……………………………… SKIPPED<br>[INFO] Activiti - OSGi …………………………….. SKIPPED<br>[INFO] Activiti - Camel ……………………………. SKIPPED<br>[INFO] Activiti - Mule …………………………….. SKIPPED<br>[INFO] Activiti - Cdi ……………………………… SKIPPED<br>[INFO] ————————————————————————<br>[INFO] BUILD FAILURE<br>[INFO] ————————————————————————<br>[INFO] Total time: 2:09.507s<br>[INFO] Finished at: Mon Mar 25 20:24:06 VET 2013<br>[INFO] Final Memory: 19M/57M<br>[INFO] ————————————————————————<br>[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.7.1:test (default-test) on project activiti-engine: There are test failures.<br>[ERROR] <br>[ERROR] Please refer to D:\gitRepo\Activiti\modules\activiti-engine\target\surefire-reports for the individual test results.<br>[ERROR] -> [Help 1]<br>org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.7.1:test (default-test) on project activiti-engine: There are test failures.<br><br>Please refer to D:\gitRepo\Activiti\modules\activiti-engine\target\surefire-reports for the individual test results.<br> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)<br> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)<br> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)<br> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)<br> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)<br> at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)<br> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)<br> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)<br> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)<br> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)<br> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)<br> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)<br> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)<br> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)<br> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)<br> at java.lang.reflect.Method.invoke(Method.java:597)<br> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)<br> at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)<br> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)<br> at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)<br> at org.codehaus.classworlds.Launcher.main(Launcher.java:47)<br> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)<br> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)<br> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)<br> at java.lang.reflect.Method.invoke(Method.java:597)<br> at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)<br>Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.<br><br>Please refer to D:\gitRepo\Activiti\modules\activiti-engine\target\surefire-reports for the individual test results.<br> at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:74)<br> at org.apache.maven.plugin.surefire.SurefirePlugin.execute(SurefirePlugin.java:631)<br> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)<br> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)<br> … 25 more<br>

The maven profile I'm using is distro, is that ok?

I'm asking too many questions, I know

I've created a pull request. I've added a test case, similar to yours, and a new bpmn for this test.
This is my first commit to an open source project, I'm sorry in advance in a case of mistake.

jbarrez

The maven profile I'm using is distro, is that ok?

Yes that is ok. You can also run -Pcheck, that is quicker.

Don't worry about the failing tests, I fixed those yesterday on master. They were indeed failing for everyone.

I've created a pull request. I've added a test case, similar to yours, and a new bpmn for this test.
This is my first commit to an open source project, I'm sorry in advance in a case of mistake.

Awesome! We'll verify the pull request shortly! Thanks for the effort!

gokceng1

Thnak you joram.