Tool (Import, Export) dont use LOG4J and invoke System.exit

As we transition to the new Hyland Community, some post links may be temporarily disrupted as we finalize redirects. We apologize for the inconvenience and are working to resolve this as quickly as possible. Details.

sbroussi

Hi,

I've noticed that the org.alfresco.tools.Tool abstract class does not use the LOG4J framework, but use "System.out" and "exception.printStackTrace()".

Moreover, the Tool class ends with System.exit(0) or System.exit(-1).

This is not so "extensible" like ALL your other services 

I propose that the Tool class:
- use the "log4j" framework
- do not invoke System.exit(..)
- let the exception be thrown outside the method to be caught by the default JVM exception handler or by a wrapper class as in this example:

import org.alfresco.tools.Import;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;

/**
 * This class is a "wrapper" to:
 * - log errors using log4j
 * - return a "exit code" different from 0 when one error occurs.
 */
public final class ImportWrapper
{
   protected static Log logger = LogFactory.getLog(ImportWrapper.class);
      
    public static void main(String[] args)
    {
       logger.debug("Start of import");
       
       int exitCode = 1;

       try
       {
          Import.main(args);
          
          // OK
          exitCode = 0;
       }
       catch (Throwable t)
       {
          logger.error("ERROR DURING IMPORT:" + t.getMessage(), t);
       }
      
       logger.debug("End of import - exitCode=" + exitCode);
       
       System.exit(exitCode);
       
    }
 

}
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

davidc

You can track fix progress at http://www.alfresco.org/jira/browse/AR-619.