activiti:delegateExpression: BpmnError not caught

As we transition to the new Hyland Community, some post links may be temporarily disrupted as we finalize redirects. We apologize for the inconvenience and are working to resolve this as quickly as possible. Details.

workflowuser2

Hi,

I have a subprocess and a boundary error event on the subprocess scope. Now, in the subprocess, I have service tasks with activiti:delegateExpression. In these java delegates, if I throw BpmnError, it is never caught and processed.

The same process works if I use java delegates (activiti:class="java.delegate.class") instead of activiti:delegateExpression.
In the regular java delegate case, I observed, org.activiti.engine.impl.bpmn.helper.ClassDelegate wraps ServiceTaskJavaDelegateActivityBehavior and process BpmnError:
try {
      activityBehaviorInstance.execute(execution);
    } catch (BpmnError error) {
      ErrorPropagation.propagateError(error, execution);
    }

However, ServiceTaskDelegateExpressionActivityBehavior call does not go through ClassDelegate and therefore does not handle BpmnError.

I hope the above information is enough to understand the bug. Since I am using OSGi, it is difficult to attach unit test.
Please let me know if I am missing something.

Process xml:

<?xml version="1.0" encoding="UTF-8"?>
<definitions xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:activiti="http://activiti.org/bpmn" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlnsmgdc="http://www.omg.org/spec/DD/20100524/DC" xmlnsmgdi="http://www.omg.org/spec/DD/20100524/DI" typeLanguage="http://www.w3.org/2001/XMLSchema" expressionLanguage="http://www.w3.org/1999/XPath" targetNamespace="http://www.activiti.org/test">
  <process id="applyProfile" name="Apply Profile">
 
 
    <startEvent id="startevent1" name="Start"></startEvent>
    <endEvent id="endevent1" name="End"></endEvent>
   
    <sequenceFlow id="flow1" name="" sourceRef="startevent1" targetRef="mainProcess"></sequenceFlow>
    <sequenceFlow id="flow2" name="" sourceRef="mainProcess" targetRef="endevent1"></sequenceFlow>
   
    <subProcess id="mainProcess">
       <startEvent id="subProcessStart" />
       <endEvent id="subProcessEnd" />
       <serviceTask id="step1" name="step1WithError" activiti:delegateExpression="${main1Delegate}"></serviceTask>
       <serviceTask id="step2" name="step2" activiti:class="com.acme.delegates.Main2Delegate"></serviceTask>
       <sequenceFlow id="flow11" sourceRef="subProcessStart" targetRef="step1" />
       <sequenceFlow id="flow12" sourceRef="step1" targetRef="step2" />
       <sequenceFlow id="flow13" sourceRef="ApplyProfile" targetRef="subProcessEnd" />
   </subProcess>
  
   <serviceTask id="errorTask" name="Global error handling" activiti:class="com.acme.delegates.Main1Delegate"></serviceTask>
    <endEvent id="errorEnd" />
    <sequenceFlow id="flow_error1" sourceRef="errorEvent" targetRef="errorTask" />
    <sequenceFlow id="flow_error2" sourceRef="errorTask" targetRef="errorEnd" />
   
   <boundaryEvent id="errorEvent" attachedToRef="mainProcess">
      <errorEventDefinition/>
   </boundaryEvent>
   
  </process>
</serviceTask> –>
 
</definitions>


main1Delegate is an OSGi service (also JavaDelegate). Now, in this java delegate, if I throw BpmnError, it is never caught and error flow is not activated.

frederikherema1

As of 5.10 (due in august), this is supported. Current trunk of ServiceTaskDelegateExpressionActivityBehavior contains:

<br> } catch (Exception exc) {<br><br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Throwable cause = exc;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; BpmnError error = null;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; while (cause != null) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (cause instanceof BpmnError) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; error = (BpmnError) cause;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; cause = cause.getCause();<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br><br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (error != null) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ErrorPropagation.propagateError(error, execution);<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; } else {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; throw exc;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br><br>&nbsp;&nbsp;&nbsp; }<br>
This was fixed this month for http://jira.codehaus.org/browse/ACT-1159. But thanks for reporting this!